refactor: switch to traefik v3 #90
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should route to a different port if specified: Failing tests (return 404 instead of 200): curl -s -o /dev/null -I -w "%{http_code}" http://lets.combine.really.lndo.site/everything/for-real | grep 200
curl -s -o /dev/null -I -w "%{http_code}" http://lets.combine.things.lndo.site/everything/for-real | grep 200Should handle sites in subdirectories: Failing tests (404 instead of 200): curl -s -o /dev/null -I -w "%{http_code}" http://lets.combine.really.lndo.site/everything/for-real | grep 200 |
proxy:
web3:
- "lets.combine.*.lndo.site:8080/everything/for-real"
- "*.more.web3.lndo.site:8080"
- web3.lndo.site:8080
- web4.lndo.site:8080
- hostname: web5.lndo.site
port: 8080 |
|
|
Traefik 3 does not seem to support named regexps. https://doc.traefik.io/traefik/v2.11/routing/routers/#rule -HostRegexp(`lets.combine.{wildcard:[a-z0-9-]+}.lndo.site`)
+HostRegexp(`lets.combine.[a-z0-9-]+.lndo.site`) |
diff --git a/plugins/lando-proxy/lib/utils.js b/plugins/lando-proxy/lib/utils.js
index 102f115e..dca72e25 100644
--- a/plugins/lando-proxy/lib/utils.js
+++ b/plugins/lando-proxy/lib/utils.js
@@ -54,7 +54,7 @@ exports.getProxyRunner = (project, files) => ({
*/
exports.getRule = rule => {
// Start with the rule we can assume
- const hostRegex = rule.host.replace(new RegExp('\\*', 'g'), '{wildcard:[a-z0-9-]+}');
+ const hostRegex = rule.host.replace(new RegExp('\\*', 'g'), '[a-z0-9-]+');
const rules = [`HostRegexp(\`${hostRegex}\`)`];
// Add in the path prefix if we can
if (rule.pathname.length > 1) rules.push(`PathPrefix(\`${rule.pathname}\`)`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.